UI: Fixes front-end API calls#11205
Closed
bernardodemarco wants to merge 2 commits intoapache:mainfrom
Closed
Conversation
bernardodemarco
requested review from
DaanHoogland,
JoaoJandre and
sureshanaparti
Contributor
|
@bernardodemarco i see some doublures to #11191 . can you rebase on top of that and see if your changes are still needed? |
Member
|
@bernardodemarco These are already fixed in #11191. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11205 +/- ##
============================================
- Coverage 16.58% 16.58% -0.01%
+ Complexity 14038 14037 -1
============================================
Files 5758 5758
Lines 511717 511733 +16
Branches 62216 62216
============================================
Hits 84871 84871
- Misses 417373 417389 +16
Partials 9473 9473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
@DaanHoogland @vishesh92 @sureshanaparti, yes, that's right. I hadn't seen it, my bad. Closing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some API calls performed by the front-end of Apache CloudStack. The #10899 PR changed some functions signatures responsible for making the API requests. However, there are still some usages of the functions with the old signatures, which is resulting in some major/blocker inconsistencies in the Apache CloudStack UI.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Fatal error during app initialization: TypeError: Object(...) is not a function at guiTheme.js:48:16